Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use obsolete X509Certificate2 ctor on .NET 9.0 #14935

Closed
wants to merge 1 commit into from

Conversation

akoeplinger
Copy link
Member

More fallout from dotnet/docs#41662

Creating as a draft since we can only merge it once arcade bumps to a preview7 SDK.

@akoeplinger akoeplinger requested a review from ViktorHofer July 15, 2024 16:23
@ViktorHofer
Copy link
Member

Can we suppress the warning in code (as we did in 04cb1e3) and file a tracking issue to remove the suppression when we update to a 9.0 P7 SDK? Asking as P7 is still a month out.

@akoeplinger
Copy link
Member Author

akoeplinger commented Jul 15, 2024

The difference with 04cb1e3 is that we can't remove the suppression in code for that use case (since there's no replacement).

I assume you mainly don't want to carry a VMR patch for the next month?

@ViktorHofer
Copy link
Member

ViktorHofer commented Jul 15, 2024

The difference with 04cb1e3 is that we can't remove the suppression in code for that use case (since there's no replacement).

I'm interested in having a green stage 2 non-source-build. We don't have that in CI today but I do use the live produced from time to time to build the product just to see if there are any new breaking changes when updating to a newer SDK.

I assume you mainly don't want to carry a VMR patch for the next month?

Yes and no. I think it's fine to carry a patch for a month. But requiring a patch and not being able to apply the change directly in tree in the affected repo, sounds problematic.


Interesting. We added the new API and obsoleted the old API in the same preview release. That puts a lot pressure on our own product construction. cc @bartonjs @vcsjones

@akoeplinger
Copy link
Member Author

Filed #14936 to track removing the suppression, closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants